Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #9962: set session at the first place when construct ConsoleWidget #9963

Merged
merged 1 commit into from
Aug 26, 2021
Merged

fix #9962: set session at the first place when construct ConsoleWidget #9963

merged 1 commit into from
Aug 26, 2021

Conversation

FinnChen
Copy link
Contributor

Signed-off-by: FinnChen [email protected]

What it does

set session at the first place when construct ConsoleWidget

fix #9962

How to test

  1. keep debug console closed
  2. clear all data in local storage
  3. launch a debug session
  4. verify the debug console widget is open and print debug log in it

Review checklist

Reminder for reviewers

@msujew msujew added the debug issues that related to debug functionality label Aug 26, 2021
@msujew
Copy link
Member

msujew commented Aug 26, 2021

Hi @FinnChen, thank you for your first contribution and taking care of this issue 👍

Please be sure to sign the eclipse contributor agreement (eca) with the same email as your authorship in order for us to accept the changes.

@FinnChen
Copy link
Contributor Author

Hi @FinnChen, thank you for your first contribution and taking care of this issue 👍

Please be sure to sign the eclipse contributor agreement (eca) with the same email as your authorship in order for us to accept the changes.

Thanks. I have signed the eca.

vince-fugnitto
vince-fugnitto approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed it fixes the issue 👍
When starting a debug session for the first time the console-widget now appears. Previously on master, the console-widget would only appear on subsequent sessions.

@paul-marechal paul-marechal merged commit 840490b into eclipse-theia:master Aug 26, 2021
@paul-marechal paul-marechal added this to the 1.17.0 milestone Aug 26, 2021
RomanNikitenko pushed a commit that referenced this pull request Sep 16, 2021
@FinnChen @RomanNikitenko
fix #9962: set session at the first place when construct `ConsoleWidg…
4d308c0 
…et` (#9963)

Signed-off-by: FinnChen <[email protected]>
RomanNikitenko pushed a commit that referenced this pull request Sep 16, 2021
@FinnChen @RomanNikitenko
fix #9962: set session at the first place when construct `ConsoleWidg…
32f02ef 
…et` (#9963)

Signed-off-by: FinnChen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
debug issues that related to debug functionality
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Debug console is empty
4 participants
@FinnChen @msujew @vince-fugnitto @paul-marechal